F1: the uninstaller keeps the Jump List of com.tyrveil.lutra
The template's DeleteAppUserModelId cleared the Jump List of the app id every Lutra install shares, so removing a test or second install wiped the list of the one in use. Marked with a Lutra: comment; a desktop test fails if the call comes back. Also rustfmt of the settings test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
f4dbc9188e
commit
1b6bd1f870
3 changed files with 21 additions and 2 deletions
|
|
@ -867,7 +867,12 @@ Section Uninstall
|
||||||
|
|
||||||
; Remove shortcuts if not updating
|
; Remove shortcuts if not updating
|
||||||
${If} $UpdateMode <> 1
|
${If} $UpdateMode <> 1
|
||||||
!insertmacro DeleteAppUserModelId
|
; Lutra: the template's `!insertmacro DeleteAppUserModelId` is left out.
|
||||||
|
; It clears the Jump List (recent and pinned files) of the app id
|
||||||
|
; com.tyrveil.lutra, which every Lutra install shares: uninstalling a
|
||||||
|
; second or test install wiped the list of the one still in use.
|
||||||
|
; Windows keeps a few kilobytes for the id after the last uninstall and
|
||||||
|
; shows them again on a reinstall.
|
||||||
|
|
||||||
; Remove start menu shortcut
|
; Remove start menu shortcut
|
||||||
!insertmacro MUI_STARTMENU_GETFOLDER Application $AppStartMenuFolder
|
!insertmacro MUI_STARTMENU_GETFOLDER Application $AppStartMenuFolder
|
||||||
|
|
|
||||||
|
|
@ -408,4 +408,14 @@ mod tests {
|
||||||
.collect();
|
.collect();
|
||||||
assert_eq!(mac_exts, windows_exts);
|
assert_eq!(mac_exts, windows_exts);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn the_uninstaller_keeps_the_jump_list_every_install_shares() {
|
||||||
|
let calls: Vec<&str> = include_str!("../installer/installer.nsi")
|
||||||
|
.lines()
|
||||||
|
.map(str::trim)
|
||||||
|
.filter(|line| line.starts_with("!insertmacro DeleteAppUserModelId"))
|
||||||
|
.collect();
|
||||||
|
assert_eq!(calls, Vec::<&str>::new());
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -723,7 +723,11 @@ mod tests {
|
||||||
assert!(s.set(key, json!(1)).is_err());
|
assert!(s.set(key, json!(1)).is_err());
|
||||||
assert!(DEFS.iter().any(|d| d.key == key && d.info().path));
|
assert!(DEFS.iter().any(|d| d.key == key && d.info().path));
|
||||||
}
|
}
|
||||||
assert!(!DEFS.iter().any(|d| d.key == "editor.fontSize" && d.info().path));
|
assert!(
|
||||||
|
!DEFS
|
||||||
|
.iter()
|
||||||
|
.any(|d| d.key == "editor.fontSize" && d.info().path)
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue