M3.5: pending outcomes for commands that wait for the language server
Step 1 of M3.5: the shared mechanism. M3.4 and M3.5 build on it. - Engine: `Outcome.pending: Option<Pending>`. `Pending::new(rx, timeout, finish)`; `Pending::wait()` is called without the engine lock and returns at the answer, a dropped sender or the deadline (timeout + 1 s). `Engine::resolve(answered)` then runs `finish(state, reply)` inside the guard, under the lock. `run_waiting(lock, cmd, params, publish)` does all three steps for hosts. - Hosts: `Host::run`, `testkit::EngineBackend` and the control test backend use `run_waiting`. - New IPC `engine_execute_waiting` (`#[tauri::command(async)]`, off the main thread) with `runWaiting()` in `ui/src/ipc.ts`. Only `lsp.*` requests use it. Ordering guarantee: - `engine_execute` stays synchronous on the main thread, so ordinary commands (`buffer.edit`) still run in call order. - The order towards the server is fixed under the engine lock: `buffer.edit` queues its didChange on the session's FIFO queue before it returns, and `lsp::submit` queues the request on the same queue. A request therefore sees every edit whose `buffer.edit` returned first, and the UI awaits the sync's `idle()` before sending one. Failures: - A stall is caught by the request timeout, with the deadline as backstop. - On restart, close, quit or crash the request is dropped or resolved as stopped, so the waiter gets an error, never a hang. Tests: `crates/engine/tests/pending.rs` (answer, lock free while waiting, dropped sender, deadline, resolve, lsp.restart while a request is pending) and Vitest for `runWaiting`. Gate: 13 steps, 321 s, Vitest 443 + 1 skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
a674040797
commit
20d1d28c32
11 changed files with 603 additions and 18 deletions
|
|
@ -283,6 +283,28 @@ export async function run<T = JsonValue>(
|
|||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Runs an engine command that waits for the language server (`lsp.*`,
|
||||
* M3.5) on a worker thread of the shell, so the window stays responsive
|
||||
* while the server works. Unlike {@link run}, calls are not ordered with
|
||||
* other commands: let edits reach the engine first (`BufferSync.idle`).
|
||||
*
|
||||
* @param commandId - the command id, e.g. `lsp.definition`.
|
||||
* @param params - the command's params object.
|
||||
* @returns the command's result, or the error it failed with.
|
||||
*/
|
||||
export async function runWaiting<T = JsonValue>(
|
||||
commandId: string,
|
||||
params: JsonValue = {},
|
||||
): Promise<RunResult<T>> {
|
||||
try {
|
||||
const value = await invoke<T>("engine_execute_waiting", { command: commandId, params });
|
||||
return { ok: true, value };
|
||||
} catch (reason: unknown) {
|
||||
return { ok: false, error: toEngineError(reason) };
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Lists every command the engine knows, with its current enabled state.
|
||||
*
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue