M1.12: notifications as toasts
The host publishes picker, command-line and pump errors as notification events (Engine::notify, same id sequence) instead of stderr, keeps notifications and watchFailed published before engine_ready and replays them after the state replay, so startup warnings (corrupt settings, journal entries) reach the UI. ipc.ts announces engine_ready once all subscriptions started together are registered. Frontend: notifications store and NotificationStack (bottom right, info auto-dismissed after 5 s, warnings/errors stay, close button and Escape, at most 5 visible with "+n more", role status/alert); watchFailed maps to a warning toast; failed commands without their own UI raise an error toast. Catalog keys notification.settings.*, project.*, vfs.*, watch.*, command.* plus the runtime allow-list. Docs updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
7b7273a947
commit
f41df518b5
21 changed files with 1178 additions and 94 deletions
|
|
@ -41,6 +41,39 @@ describe("onEngineEvent", () => {
|
|||
expect(unlisten).toHaveBeenCalledTimes(2);
|
||||
});
|
||||
|
||||
it("announces readiness only after every subscription started together is registered", async () => {
|
||||
const resolvers: ((fn: () => void) => void)[] = [];
|
||||
listen.mockImplementation(
|
||||
() =>
|
||||
new Promise<() => void>((resolve) => {
|
||||
resolvers.push(resolve);
|
||||
}),
|
||||
);
|
||||
const { onEngineEvent } = await import("../src/ipc");
|
||||
onEngineEvent(() => undefined);
|
||||
const stopSecond = onEngineEvent(() => undefined);
|
||||
resolvers[0]?.(() => undefined);
|
||||
await flushPromises();
|
||||
expect(invoke).not.toHaveBeenCalled();
|
||||
stopSecond();
|
||||
resolvers[1]?.(() => undefined);
|
||||
await flushPromises();
|
||||
expect(invoke).toHaveBeenCalledTimes(1);
|
||||
expect(invoke).toHaveBeenCalledWith("engine_ready");
|
||||
});
|
||||
|
||||
it("does not announce readiness without a live subscription", async () => {
|
||||
listen.mockResolvedValue(() => undefined);
|
||||
const { onEngineEvent } = await import("../src/ipc");
|
||||
const stop = onEngineEvent(() => undefined);
|
||||
stop();
|
||||
await flushPromises();
|
||||
expect(invoke).not.toHaveBeenCalled();
|
||||
onEngineEvent(() => undefined);
|
||||
await flushPromises();
|
||||
expect(invoke).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("unlistens a subscription that was cancelled before it started", async () => {
|
||||
const unlisten = vi.fn();
|
||||
listen.mockResolvedValue(unlisten);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue