Lutra/ui/tests/editor/assist/fakes.ts
danny a212a44490 M3.4: completion, hover and signature help from Phpactor
Engine (crates/engine/src/cmd/lsp_assist.rs), on M3.5's pending outcomes:
- lsp.completion {id, position, triggerCharacter?}: items with label,
  kind, detail, Markdown documentation, insertText, textEdit,
  additionalTextEdits, sortText; sorted, capped at 500 (cut lists are
  incomplete), snippets turned into plain text.
- lsp.hover {id, position}: Markdown contents and range.
- lsp.signatureHelp {id, position}: signatures with UTF-16 parameter spans.
- The request is queued after every didChange; the answer is converted
  in the reply callback, off the engine lock. Positions are checked
  against the buffer. Server strings and lists are capped.
- lutra-lsp-fake answers completion and signature help.

Editor (ui/src/components/editor/assist/):
- Completion source with Lutra's triggers (identifiers, $, ->, ?->, ::,
  namespace \; not in strings or comments unless asked), the server's
  ranking as boost, text edits and imports applied in UTF-16 (CRLF too),
  Lucide kind icons.
- Hover documentation (350 ms) and editor.quickDocumentation (Mod+I).
- Signature help on ( and , following the cursor; editor.parameterInfo.
- editor.complete.
- Lutra's own Markdown renderer without HTML (XSS-tested), tokens only.
- Requests wait for the buffer sync to be idle and use runWaiting.
- New dependency @codemirror/autocomplete (MIT, already transitive).

Tests: 6 engine tests against the fake server, 9 unit tests, an ignored
real-Phpactor latency test, 29 Vitest tests; palette and menu tests list
the new UI commands.

Measured with the real Phpactor (Windows 11, debug build, 25 ms tick):
- Completion 61-109 ms while typing (median 76 ms; ~107 ms in the app).
- Hover and signature help ~16 ms median.
- A useful list 2.3 s after opening a file in a 20-class project, ~65 s
  for 2,000 classes (indexing).
- Phpactor 56-71 MB working set, ~6% of one core while typing.

Live-checked in the app on port 7934. Docs: Code completion 0% -> 5%
(est.), feature depth ~4.1% -> ~4.6%, breadth 26/155, architecture, G6,
ui-parity, language-parity, roadmap, README.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-22 18:38:07 +02:00

41 lines
1.2 KiB
TypeScript

/**
* Fakes for the assist tests: a transport that records queries and
* answers with a fixed result, and a buffer whose sync is always idle.
*/
import type { AssistBuffer, AssistTransport } from "../../../src/components/editor/assist/types";
import type { EngineError, JsonValue } from "../../../src/ipc";
/** A recording transport. */
export interface FakeTransport extends AssistTransport {
/** The queries sent, in order. */
calls: { command: string; params: JsonValue }[];
}
/**
* A transport that answers every query with `value`, or fails with
* `error`.
*/
export function fakeTransport(value: unknown, error?: EngineError): FakeTransport {
const calls: { command: string; params: JsonValue }[] = [];
return {
calls,
query: (command, params) => {
calls.push({ command, params });
return Promise.resolve(error ? { ok: false, error } : { ok: true, value });
},
};
}
/** A buffer that counts idle waits; `onIdle` runs inside each one. */
export function fakeBuffer(id: number, onIdle?: () => void): AssistBuffer & { idleCalls: number } {
const buffer = {
id,
idleCalls: 0,
idle: (): Promise<void> => {
buffer.idleCalls += 1;
onIdle?.();
return Promise.resolve();
},
};
return buffer;
}